WIP: Implement orchestrion-based instrumentation for vercel-ai v6#21658
Draft
mydea wants to merge 3 commits into
Draft
WIP: Implement orchestrion-based instrumentation for vercel-ai v6#21658mydea wants to merge 3 commits into
mydea wants to merge 3 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mydea
force-pushed
the
fn/vercel-ai-v7
branch
9 times, most recently
from
9145703 to
abad3a9
Compare
mydea
force-pushed
the
fn/try-orchestrion
branch
from
3417464 to
d05d40e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d05d40e. Configure here.
| asyncLocalStorage: lookup.asyncLocalStorage, | ||
| getStoreWithActiveSpan: (span: Span) => api.trace.setSpan(api.context.active(), span as api.Span), | ||
| asyncLocalStorage, | ||
| getStoreWithActiveSpan: span => api.trace.setSpan(api.context.active(), span as api.Span), |
There was a problem hiding this comment.
Empty binding skips retry
Medium Severity
With skipOpenTelemetrySetup, getTracingChannelBinding can return a binding whose asyncLocalStorage is still undefined when the global OpenTelemetry context manager is not registered yet. waitForTracingChannelBinding treats any truthy binding as ready, so it runs channel subscribers immediately during Sentry.init() instead of retrying after the user registers their context manager.
Reviewed by Cursor Bugbot for commit d05d40e. Configure here.
| // If it still fails, we bail and do nothing | ||
| setTimeout(() => { | ||
| waitForTracingChannelBinding(callback, retries - 1); | ||
| }, 1); |
There was a problem hiding this comment.
Timer missing safeUnref call
Low Severity
waitForTracingChannelBinding schedules a setTimeout retry in @sentry/core without calling safeUnref (or unref), which can keep short-lived Node processes alive until the timer fires.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit d05d40e. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP...
This is on top of #21613
When using orchestrion, this replaces the regular
vercelAiIntegrationwith the channel-variant. This today supports vercel ai v6 and v7 (v5/v4 support TBD).Test coverage exists and everything passes. This does not add any event processors etc. anymore, everything works inside of the integrations.
OTEL Spans emitted directly by vercel-ai v6 or below are ignored to avoid double instrumentation.